Open
Conversation
Support for PHP4 and PHP5 is dropped
Convert while (list($key, $var) = each($array)) to foreach()
Convert any array {} lookups to []
Upgrade libchart to 1.3 (final)
Upgrade Snoopy to 2.0.0 (final)
Upgrade PHPMailer to 5.2.28 (final before 6.x rewrite)
Upgrade PHPThumb to 1.7.17 (
Remove earlier libchart versions.
Fix many uninitialized values (fixes warnings in logs)
Signed-off-by: Nathaniel Clark <Nathaniel.Clark@misrule.us>
Signed-off-by: Nathaniel Clark <Nathaniel.Clark@misrule.us>
phplint: "php -l" on each php file A few more warnings, and bugs squashed. Signed-off-by: Nathaniel Clark <Nathaniel.Clark@misrule.us>
NicFord1
reviewed
Oct 19, 2021
Remove some unused "$key" variables in foreach statements. Use ?? operator instead of checking isset() in some places. Signed-off-by: Nathaniel Clark <Nathaniel.Clark@misrule.us>
Signed-off-by: Nathaniel Clark <Nathaniel.Clark@misrule.us>
Signed-off-by: Nathaniel Clark <Nathaniel.Clark@misrule.us>
borrow.php: Fix incorrect constant name Fix warnings of uninitialized variables. Signed-off-by: Nathaniel Clark <Nathaniel.Clark@misrule.us>
Signed-off-by: Nathaniel Clark <Nathaniel.Clark@misrule.us>
Also more warnings Signed-off-by: Nathaniel Clark <Nathaniel.Clark@misrule.us>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support for PHP4 and PHP5 is dropped
Convert while (list($key, $var) = each($array)) to foreach()
Convert any array {} lookups to []
Upgrade libchart to 1.3 (final)
Upgrade Snoopy to 2.0.0 (final)
Upgrade PHPMailer to 5.2.28 (final before 6.x rewrite)
Upgrade PHPThumb to 1.7.17 (
Remove earlier libchart versions.
Fix many uninitialized values (fixes warnings in logs)